Update README.md with information of the model configuration file #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PRs are now merged, so moving this out of draft |
aidanheerdegen
requested changes
Feb 25, 2025
Co-authored-by: Aidan Heerdegen <[email protected]>
|
Thanks for the reviews and suggestions! Have added them in |
anton-seaice
previously approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Looks great @jo-basevi - many wording suggestions, some more useful than others
Update README.md with review suggestions Co-authored-by: Anton Steketee <[email protected]>
jo-basevi
dismissed stale reviews from anton-seaice and aidanheerdegen
via
ad48594
|
Thanks for all the suggestions! The scheduled section/s might need to be updated depending on this issue #118 but that also can be handled in a separate PR. |
Co-authored-by: Anton Steketee <[email protected]>
anton-seaice
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added description of
config/ci.jsonwith some information from https://github.com/ACCESS-NRI/model-configs-template/blob/main/README-DEV.md#ci-configuration. I think it makes the most sense to put this description in this repository so it can be easily updated and have links to this section from theACCESS-NRI/model-configs-templaterepository.I'll leave this draft for now as it references open PRs #113 and #111 for adding more flexibility to the configuration file.
Closes #107