change_dump_date.py #19
Open
+512
−16,866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atteggiani
changed the title
Converted to mule. Still unsure if changing the correct times
Minor changes Co-authored-by: Davide Marchegiani <[email protected]>
Co-authored-by: Davide Marchegiani <[email protected]>
Added the date type function
added the date option yyyymmdd. still need to add the non integer catch
Added the exclusivity to the parser
made the parse arg and individual parameter edits
Co-authored-by: Davide Marchegiani <[email protected]>
Change to the date_value function
Unit tests update
Change dump date unit tests
Removing leftover print statements from testing
atteggiani
requested changes
Feb 27, 2025
There was a problem hiding this comment.
Thank you @leoberhelman for working on this and for adding tests.
I added some more comments to the main script.
As usual, I haven't reviewed too much of the tests because the main function has some outstanding comments.
I will review tests when those comments are addressed.
Comment on lines
+224
to
+230
| for field in ff.fields: | ||
| if new_year is not None: | ||
| field.lbyr = new_year | ||
| if new_month is not None: | ||
| field.lbmon = new_month | ||
| if new_day is not None: | ||
| field.lbdat = new_day |
There was a problem hiding this comment.
Shouldn't we also change the "Data time for instantaneous field" (PP Header 7-9: field.lbyrd, field.lbmond, field.lbdatd)?
@MartinDix
Recommit
Co-authored-by: Davide Marchegiani <[email protected]>
Co-authored-by: Davide Marchegiani <[email protected]>
Co-authored-by: Davide Marchegiani <[email protected]>
Make the changes to separate the exclusivity test
delete the extra parse date function resume the original format of parsing the --date in the parse_args()
Co-authored-by: Davide Marchegiani <[email protected]>
Co-authored-by: Davide Marchegiani <[email protected]>
Co-authored-by: Davide Marchegiani <[email protected]>
Co-authored-by: Davide Marchegiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #16