Feature/user data login #38
Conversation
(scenarios and user stuff)
removes unnecessary usings
| "environmentVariables": { | ||
| "ASPNETCORE_ENVIRONMENT": "Development" | ||
| }, | ||
| "applicationUrl": "https://localhost:5001;http://localhost:5000;http://localhost" |
There was a problem hiding this comment.
- where there any changes? why was this added?
There was a problem hiding this comment.
The redirect after the login or logout is only possible to "localhost", so I had to add this to do the redirect.
| [Route("api/[controller]")] | ||
| public sealed class LogoutController : Controller | ||
| { | ||
| public LogoutController() |
There was a problem hiding this comment.
- Do we need this empty method?
- I think backend will populate the route for frontend anyway
src/web/Startup.cs
Outdated
| .AddHttpClient<IHistoricalDataService, HistoricalDataService>(); | ||
| services | ||
| .AddHttpClient<IHistoricConditionsService, HistoricConditionsService>(); | ||
| // services |
| @NgModule({ | ||
| declarations: [ScenarioUserDataComponent], | ||
| imports: [ | ||
| CommonModule, |
There was a problem hiding this comment.
Should already be imported/exported in shared module
| @Injectable({ | ||
| providedIn: 'root' | ||
| }) | ||
| export class ScenarioUserdataService { |
There was a problem hiding this comment.
typo -> "Data" + see other files for same service
| } | ||
|
|
||
| logout() { | ||
| const redirectUri = window.location.origin + "/scenario-userdata/logout"; |
There was a problem hiding this comment.
i would like to get rid ot the window.* object in favor of using angular angular router.createUrlTree
|
|
||
| @NgModule({ | ||
| declarations: [LogoutComponent], | ||
| imports: [CommonModule, LogoutRoutingModule, SharedModule] |
There was a problem hiding this comment.
Remove CommonModule due to import/export in shared module
| this.router.navigate(["/scenario-userdata"]); | ||
| // successfully authenticated | ||
| } | ||
| // todo: handle logout param |
| templateUrl: "./scenario-userdata.component.html" | ||
| }) | ||
| export class ScenarioUserDataComponent implements OnInit, OnDestroy { | ||
| ngOnDestroy(): void { |
| loadChildren: "./scenario-historicaldata/scenario-historicaldata.module#ScenarioHistoricaldataModule" | ||
| }, | ||
| { | ||
| path: 'scenario-machinestate', |
There was a problem hiding this comment.
use single or double quotes. i would prefer double quotes, because single quotes remembers me of c character initialization and not a string :D
No description provided.