Replace explicit input_image_item_index by token #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the comments of the SampleTransform syntax code snippet. Refactor Table 2 columns.
This was referenced Sep 20, 2024
Merged
wantehchang
approved these changes
Sep 20, 2024
| <h5 id="sample-transform-constraints">Constraints</h5> | ||
|
|
||
| [=Sample Transform Derived Image Items=] use the postfix notation to evaluate the result of the whole expression for each reconstructed image item sample. | ||
|
|
||
| - The tokens shall be evaluated in the order they are defined in the metadata (the <code>SampleTransform</code> structure) of the [=Sample Transform Derived Image Item=]. | ||
| - <code>token</code> shall be at most <code>[=reference_count=]</code> when evaluating a sample operand (when <math><mn>1</mn><mo>≤</mo><mi>token</mi><mo>≤</mo><mn>32</mn></math>). |
There was a problem hiding this comment.
Should we say somewhere that reference_count shall be <= 32?
There was a problem hiding this comment.
This is not strictly necessary. One stronger constraint could be "all input image items have to be referenced by at least one sample operand token". But it does not bring much to implementations in my opinion, even with a "should", so I would rather avoid it. Files with unused input image items are pretty harmless, is it worth rejecting them?
There was a problem hiding this comment.
One benefit of this constraint would be an explicit limit of 32 input image items. The current wording is indirect.
leo-barnes
approved these changes
Sep 24, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 24, 2024
SHA: 81ad232 Reason: push, by y-guyon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the comments of the SampleTransform syntax code snippet. Refactor Table 2 columns.
Preview | Diff