Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue #178 #225

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

khushi-hura
Copy link

Description

The monument details view was showing two circular progress indicators and now it shows one circular progress indicator which is logically true.

Fixes #178

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (does not change functionality, e.g. code style improvements, linting)

image
before

Screenshot_20250101-124316 1
after

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@khushi-hura khushi-hura requested a review from jddeep as a code owner January 11, 2025 10:34
@khushi-hura
Copy link
Author

hey @mdmohsin7 please look into this!

@mdmohsin7
Copy link
Collaborator

Hi @khushi-hura, the committed changes only update the links in the script

@khushi-hura
Copy link
Author

@mdmohsin7 can u plz elaborate?
Unable to understand :(

@kareemabdeen
Copy link
Contributor

@khushi-hura I've looked at the PR you submitted too, and it looks like the changes are only about updating the data file in.js, which doesn’t seem related to the issue we're trying to resolve. Could you please make sure the PR addresses the specific issue mentioned?
I think this is what Mohamed wants to clarify@mdmohsin7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple loading indicators in monument details view
3 participants