Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use generic app bar over all app screens ✅ #238

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

kareemabdeen
Copy link
Contributor

Description

Added a reusable CustomMobileAppBar widget to improve the app bar's flexibility and reusability across the Monumento app. The widget now supports dynamic logos, actions, and leading widgets, allowing for consistent design and functionality.

Type of change

  • New feature (non-breaking change which adds functionality)

Current app view

WhatsApp.Video.2025-01-25.at.5.12.50.PM.mp4

How Has This Been Tested?

  • Verified that the CustomMobileAppBar displays the logo correctly when provided.
  • Tested dynamic actions with multiple IconButton widgets.
  • Checked conditional rendering of leading and actions when they are null.
  • Tested responsiveness across different screen sizes.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • [] I have added tests that prove my fix is effective or that my feature works.
  • [] New and existing unit tests pass locally with my changes.
  • [] Any dependent changes have been merged and published in downstream modules.
  • I have checked my code and corrected any misspellings.

Maintainer Checklist

  • [] closes # (Replace with the GitHub issue number)
  • [] Tag the PR with the appropriate labels

@kareemabdeen kareemabdeen requested a review from jddeep as a code owner January 25, 2025 15:20
@kareemabdeen
Copy link
Contributor Author

@mdmohsin7 Can you please check this PR?🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant