feat: add type information for execution difference #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
commented
May 15, 2023
Comment on lines
+241
to
+302
| private String findType(String prefix, String expectedHash, List<RuntimeValue> candidateRuntimeValues) { | ||
| for (RuntimeValue runtimeValue : candidateRuntimeValues) { | ||
|
|
||
| RuntimeValue runtimeValueFromHash = getRuntimeValueFromHash(prefix, runtimeValue, expectedHash); | ||
|
|
||
| if (runtimeValueFromHash != null) { | ||
| return runtimeValueFromHash.getType(); | ||
| } | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| private RuntimeValue getRuntimeValueFromHash(String prefix, RuntimeValue valueJo, String expectedHash) { | ||
| if (Constants.FILE_RELATED_CLASSES.stream().anyMatch(valueJo.getType()::contains)) { | ||
| return valueJo; | ||
| } | ||
|
|
||
| if (valueJo.getFields() != null && !valueJo.getFields().isEmpty()) { | ||
| if (valueJo.getKind() == RuntimeValue.Kind.RETURN) { | ||
| prefix += "."; | ||
| } else { | ||
| prefix += (valueJo.getName() == null ? "" : valueJo.getName() + "."); | ||
| } | ||
| List<RuntimeValue> nestedTypes = valueJo.getFields(); | ||
|
|
||
| for (RuntimeValue nestedObj : nestedTypes) { | ||
| RuntimeValue runtimeValue = getRuntimeValueFromHash(prefix, nestedObj, expectedHash); | ||
| if (runtimeValue != null) { | ||
| return runtimeValue; | ||
| } | ||
| } | ||
| } else if (valueJo.getArrayElements() != null | ||
| && !valueJo.getArrayElements().isEmpty()) { | ||
| List<RuntimeValue> nestedTypes = valueJo.getArrayElements(); | ||
|
|
||
| prefix += (valueJo.getName() == null ? "" : valueJo.getName()); | ||
|
|
||
| for (int i = 0; i < nestedTypes.size(); i++) { | ||
| RuntimeValue nestedObj = nestedTypes.get(i); | ||
| String currentPrefix = prefix + "[" + i + "]."; | ||
| RuntimeValue runtimeValue = getRuntimeValueFromHash(currentPrefix, nestedObj, expectedHash); | ||
| if (runtimeValue != null) { | ||
| return runtimeValue; | ||
| } | ||
| } | ||
| } else { | ||
| // it's a leaf node | ||
| String currentPrefix; | ||
| if (valueJo.getKind() == RuntimeValue.Kind.RETURN) { | ||
| currentPrefix = prefix; | ||
| } else { | ||
| currentPrefix = prefix + (valueJo.getName() == null ? "" : valueJo.getName()); | ||
| } | ||
| String value = String.valueOf(valueJo.getValue()); | ||
| String actualHash = currentPrefix + "=" + value; | ||
| if (actualHash.equals(expectedHash)) { | ||
| return valueJo; | ||
| } | ||
| } | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
@khaes-kth I am not proud of the code I wrote. Can you help me refactor it? Especially this block. It is a duplicate of extractVarVals.
|
This was just an illustration of the concept. Won't integrate it now. Would be done after #230. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208