Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update state version to 1 on acala #2799

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Aug 28, 2024

#2467

follow up #2759 #2762

@zjb0807 zjb0807 requested a review from xlc August 28, 2024 01:45
@@ -1969,8 +1947,6 @@ construct_runtime!(
// Parachain System, always put it at the end
ParachainSystem: cumulus_pallet_parachain_system = 30,

StateTrieMigration: pallet_state_trie_migration = 254,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a migration to cleanup storages?

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.23%. Comparing base (4c725dd) to head (b4f29e3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2799      +/-   ##
==========================================
+ Coverage   65.19%   65.23%   +0.04%     
==========================================
  Files          67       69       +2     
  Lines        9512    10011     +499     
==========================================
+ Hits         6201     6531     +330     
- Misses       3311     3480     +169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants