-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scss file update #22
Scss file update #22
Conversation
1) Updated File paths in package.json; added license (MPL). 2) Updated README.md; start-server, build:css, live-server. 3) Added SCSS files in assests 4)Added style.css in assets. 5) Added JS> script.js in assets. 6) Added 3rd Party License.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to fc9c94d in 14 seconds
More details
- Looked at
461
lines of code in16
files - Skipped
2
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. SCSS references.md:24
- Draft comment:
There's a syntax error in the mixin definition and usage example:
@mixin mixin-name{
// Code Goes here
}
And to call a mixin, it should be:
.img{
@include mixin-name;
}
Please correct the mixin definition and its usage example.
- Reason this comment was not posted:
Multiple suggestions found in comment body, which is not allowed by GitHub
Workflow ID: wflow_gU2VUVp7xTkLL9rb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Looks good. But still using bootstrap. You should also remove this import then try to style using scss. |
I think we should try to avoid writing SCSS ourselves, and use tailwind or
shadcn when possible.
…On Sun, Aug 11, 2024, 18:00 Brayo ***@***.***> wrote:
Looks good. But still using bootstrap. You should also remove this
<https://github.com/avadhut-the-merciful/aw-leaderboard-firebase/blob/fc9c94de2af00357a8edc3fc1e93799c8cc5a458/index.html#L9-L12>
import then try to style using scss.
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKXDOVPMEIZNSHLPKEGW5DZQ6DAJAVCNFSM6AAAAABMK3JLNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSHAYDIOJQGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Will look into shadcn. I have limited experience with tailwind but I guess I could manage a PR soon. |
Summary:
This PR adds a structured SASS architecture, updates build scripts, and includes documentation and third-party attributions.
Key points:
src/assets
using 7-in-1 architecture.package.json
with scripts for SASS compilation, prefixing, and compression.BEM reference.md
andSCSS references.md
for documentation.THIRD_PARTY_LICENSES.md
for third-party attributions.src/sass/_utilities.scss
and mixins insrc/sass/_mixins.scss
.src/sass/main.scss
imports all components in a specific order.Generated with ❤️ by ellipsis.dev