Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored API code into subpackage #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Apr 2, 2019

The idea is to split the big resources.py file into smaller files, like the code examples for flask-restplus.

@ghost ghost assigned ErikBjare Apr 2, 2019
@ghost ghost added the review label Apr 2, 2019
@johan-bjareholt
Copy link
Member

Why are you working on refactoring aw-server-python when aw-server-rust has feature parity and will be replacing it?

@ErikBjare
Copy link
Member Author

ErikBjare commented May 6, 2019

Because it is still the reference implementation, and faster to prototype stuff in.

@johan-bjareholt
Copy link
Member

But it's just refactorization, it doesn't add any functionality? Why spend time on refactoring something that we don't intend to keep for a longer period of time?

@ErikBjare
Copy link
Member Author

ErikBjare commented May 6, 2019

Because I wanted it to follow the coding conventions of the flask-restplus example projects, which will make it easier for me to follow the examples here (JWT) and here (OAuth2) as well as make me properly learn how to structure flask-restplus projects in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants