-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to tauri 2.0 #21
base: master
Are you sure you want to change the base?
Conversation
- Update package.json and package-lock.json with Tauri 2.0 dependencies - Update Cargo.toml and Cargo.lock for Tauri 2.0 - Update tauri.conf.json for Tauri 2.0 format - Update TypeScript and Vite configurations
- Add Tauri 2.0 capabilities and schemas - Update main.rs and manager.rs for Tauri 2.0 APIs - Add lib.rs for shared functionality - Implement new Tauri 2.0 system tray features
- Update App.vue for Tauri 2.0 APIs - Update main.ts entry point - Update index.html template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to d92dfad in 3 minutes and 19 seconds
More details
- Looked at
8216
lines of code in19
files - Skipped
2
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. vite.config.ts:10
- Draft comment:
Consider making the development server port configurable or handle port conflicts gracefully to avoid issues if the port is already in use. - Reason this comment was not posted:
Confidence changes required:50%
Thevite.config.ts
file has a hardcoded port number for the development server. This could cause conflicts if the port is already in use. It's better to make this configurable or handle port conflicts gracefully.
2. src-tauri/Cargo.lock:295
- Draft comment:
Thejni
package version inCargo.lock
is0.21.1
, but inCargo.toml
, it is specified as0.20.0
. Ensure both files have consistent versions to avoid potential issues. - Reason this comment was not posted:
Comment did not seem useful.
3. src-tauri/Cargo.lock:308
- Draft comment:
Ensure that the version downgrades for dependencies liketoml
are intentional and compatible with Tauri 2.0. This could potentially introduce compatibility issues or bugs. - Reason this comment was not posted:
Confidence changes required:50%
The PR updates the Tauri version and related dependencies. However, theCargo.lock
file has a lot of changes, including version downgrades for some dependencies liketoml
. This could potentially introduce compatibility issues or bugs. It's important to ensure that all dependencies are compatible with the new Tauri version.
Workflow ID: wflow_ulTH9yzplW7aQZtp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
7bc778a
to
6e26d45
Compare
6e26d45
to
93d5a86
Compare
Most of these are failing because of a new library that needs a custom_build command for. |
Co-authored-by: Erik Bjäreholt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to review, but looks good!
What's up with all the schemas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these schemas need to be committed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They seem to be autogenerated. No need to track. I deleted them and make dev
runs. make build
regenerates them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tauri website says they are for autocompletion in IDE. link. Let's keep them for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a duplicate of linux-schema.json?
Ubuntu build fails with:
I guess it needs some glib apt package? |
Will try fixing the tests tonight |
Important
Migrate project to Tauri 2.0, updating dependencies, refactoring code, and adding new capabilities and permissions.
package.json
dependencies to Tauri 2.0 and related plugins.Cargo.lock
with new versions of dependencies.tauri.conf.json
to use Tauri 2.0 schema.main.rs
tolib.rs
and updatemain.rs
to callaw_tauri_lib::run()
.manager.rs
to use Tauri 2.0 APIs.src-tauri/capabilities
andsrc-tauri/gen/schemas
.greet
command inlib.rs
and updateApp.vue
to use it.vite.config.ts
for Tauri 2.0 compatibility.tsconfig.node.json
for module resolution changes.This description was created by for d92dfad. It will automatically update as commits are pushed.