Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper - Whit #47

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Paper - Whit #47

wants to merge 13 commits into from

Conversation

sundbean
Copy link

@sundbean sundbean commented Jun 8, 2021

progress is ongoing

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: You do NOT need a venv for an HTML project...

As you mentioned, the site is unfinished, but the layout looks nice and it hits most requirements. I made a few comments in the code, but it's overall pretty well written with clear CSS and readable HTML.

<html>
<head>
<meta charset="utf-8">
<title></title>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty title

about.html Outdated
Comment on lines 17 to 19
<a class="current-page" href="./about.html">About</a></li>
<a href="./portfolio.html">Portfolio</a></li>
<a href="./blog.html">Essays</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have close li tags, but no ul and no open li tags. You should have an ul or something as well as li start tags.

blog.html Outdated
Comment on lines 16 to 20
<nav class="navbar">
<a class="current-page" href="./about.html">About</a></li>
<a href="./portfolio.html">Portfolio</a></li>
<a href="./blog.html">Essays</a></li>
</nav>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar issues to the about page.

index.html Outdated
Comment on lines 25 to 27
<article class="card">
<img src="./images/video_store.jpg" alt="A storefront sign that says 'VIDEO'." />
<!-- <section class="card_text">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, that these images really squish down when the screen size is small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants