-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rock- Adelaide #57
base: master
Are you sure you want to change the base?
Rock- Adelaide #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great color scheme and fun styling, Adelaide! Good job!
</p> | ||
<br> | ||
<br> | ||
<br> | ||
<br> | ||
<br> | ||
<br> | ||
<br> | ||
<br> | ||
<br> | ||
<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one cool trick we can do instead of adding all these <br/>
is giving the <p>
element extra bottom margin instead
@@ -0,0 +1,252 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nicely done with the CSS!!
url("../images/F712B13B-871F-489F-B519-00BB1164EA4A_1_105_c.jpeg"); */ | ||
/* background-image: url("../images/748CFF9B-BDF1-42D9-97C7-1972B52FCC07_1_102_o.jpeg"); */ | ||
/* background-size: contain; */ | ||
/* background-position: right; */ | ||
/* background-repeat: no-repeat; */ | ||
/* background-color: #f1e6d8; */ | ||
/* } | ||
|
||
/*lightens backgroun img a bit */ | ||
/* #index:after { | ||
content: ""; | ||
position: fixed; | ||
top: 0; bottom: 0; left: 0; rigt: 0; | ||
background: rgba(249, 247, 247, 0.25); | ||
pointer-events: none; | ||
} */ | ||
|
||
/* #portfolio { | ||
font-family: Arial, Helvetica, sans-serif; | ||
/* background: #acabd2; */ | ||
/* background-image: linear-gradient(rgba(131, 122, 122, 0.5), rgba(142, 118, 118, 0.5)), | ||
url("../images/F712B13B-871F-489F-B519-00BB1164EA4A_1_105_c.jpeg"); */ | ||
/* background-image: url("../images/F712B13B-871F-489F-B519-00BB1164EA4A_1_105_c.jpeg"); | ||
background-size: cover; | ||
background-position: center; | ||
background-repeat: no-repeat; */ | ||
/* background-position: center; */ | ||
|
||
/* width: 400px; | ||
height: 400px; */ | ||
/* border: 2px dashed #333; */ | ||
|
||
/* margin: 10; | ||
padding: 10; */ | ||
/* } */ | ||
|
||
/* lightens backgroun img a bit | ||
#portfolio:after { | ||
content: ""; | ||
position: fixed; | ||
top: 0; bottom: 0; left: 0; right: 0; | ||
background: rgba(206, 204, 204, 0.25); | ||
pointer-events: none; | ||
} */ | ||
|
||
/* | ||
h1, h2, h3, h4 { | ||
color: #1a0715; | ||
} */ | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
/* #background { | ||
max-width: 80vm; | ||
border: 0.5em solid #b4911f; | ||
} */ | ||
|
||
/* header { | ||
grid-column: span 2; | ||
text-align: center; | ||
} */ | ||
|
||
/* footer { | ||
background: #5f6c7b; | ||
margin-top: 1em; | ||
padding: 1em 2em; | ||
display: flex; | ||
flex-direction: row; | ||
justify-content: space-between; | ||
grid-column: span 2; | ||
} */ | ||
|
||
/* footer p { | ||
margin: 0; | ||
} */ | ||
|
||
/* main { | ||
display: grid; | ||
grid-template-columns: 1fr 4fr; | ||
grid-template-rows: auto 1fr auto; | ||
max-width: 60em; | ||
margin-left: auto; | ||
margin-right: auto; | ||
min-height: 100vh; | ||
} */ | ||
|
||
|
||
|
||
/* nav { */ | ||
|
||
/* grid-column: 1; */ | ||
/* grid-row: 2; */ | ||
/* } */ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you aren't using this for the final submissions, think about deleting it
/* #index { */ | |
/* background: #acabd2; */ | |
/* background-image: linear-gradient(rgba(131, 122, 122, 0.5), rgba(142, 118, 118, 0.5)), | |
url("../images/F712B13B-871F-489F-B519-00BB1164EA4A_1_105_c.jpeg"); */ | |
/* background-image: url("../images/748CFF9B-BDF1-42D9-97C7-1972B52FCC07_1_102_o.jpeg"); */ | |
/* background-size: contain; */ | |
/* background-position: right; */ | |
/* background-repeat: no-repeat; */ | |
/* background-color: #f1e6d8; */ | |
/* } | |
/*lightens backgroun img a bit */ | |
/* #index:after { | |
content: ""; | |
position: fixed; | |
top: 0; bottom: 0; left: 0; rigt: 0; | |
background: rgba(249, 247, 247, 0.25); | |
pointer-events: none; | |
} */ | |
/* #portfolio { | |
font-family: Arial, Helvetica, sans-serif; | |
/* background: #acabd2; */ | |
/* background-image: linear-gradient(rgba(131, 122, 122, 0.5), rgba(142, 118, 118, 0.5)), | |
url("../images/F712B13B-871F-489F-B519-00BB1164EA4A_1_105_c.jpeg"); */ | |
/* background-image: url("../images/F712B13B-871F-489F-B519-00BB1164EA4A_1_105_c.jpeg"); | |
background-size: cover; | |
background-position: center; | |
background-repeat: no-repeat; */ | |
/* background-position: center; */ | |
/* width: 400px; | |
height: 400px; */ | |
/* border: 2px dashed #333; */ | |
/* margin: 10; | |
padding: 10; */ | |
/* } */ | |
/* lightens backgroun img a bit | |
#portfolio:after { | |
content: ""; | |
position: fixed; | |
top: 0; bottom: 0; left: 0; right: 0; | |
background: rgba(206, 204, 204, 0.25); | |
pointer-events: none; | |
} */ | |
/* | |
h1, h2, h3, h4 { | |
color: #1a0715; | |
} */ | |
/* #background { | |
max-width: 80vm; | |
border: 0.5em solid #b4911f; | |
} */ | |
/* header { | |
grid-column: span 2; | |
text-align: center; | |
} */ | |
/* footer { | |
background: #5f6c7b; | |
margin-top: 1em; | |
padding: 1em 2em; | |
display: flex; | |
flex-direction: row; | |
justify-content: space-between; | |
grid-column: span 2; | |
} */ | |
/* footer p { | |
margin: 0; | |
} */ | |
/* main { | |
display: grid; | |
grid-template-columns: 1fr 4fr; | |
grid-template-rows: auto 1fr auto; | |
max-width: 60em; | |
margin-left: auto; | |
margin-right: auto; | |
min-height: 100vh; | |
} */ | |
/* nav { */ | |
/* grid-column: 1; */ | |
/* grid-row: 2; */ | |
/* } */ |
No description provided.