Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tigers - Melley Gebretatios and QP #22

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
97f9ff4
pass test wave 1
mell2022 Oct 4, 2022
fd4c094
commited out skip on test wave 1
Oct 4, 2022
20b4c50
commiting vendor.py
Oct 4, 2022
e34b241
Merge branch 'master' of https://github.com/mell2022/swap-meet
Oct 4, 2022
0440e36
tests pass wave 2, adde d vendor method and item attribute.
mell2022 Oct 4, 2022
c484fb5
item and test_wave 2 changes
Oct 4, 2022
442f863
item vendor and test_wave2 merged
Oct 4, 2022
9a67a4b
Wave 3 all tests pass and added swap items to vendor.py and stringify.
mell2022 Oct 4, 2022
1f52e52
updated wave_3
Oct 4, 2022
c952e39
solved merged conflicts
Oct 4, 2022
f0fe840
Test wave 4 pass addedd first swap item.
mell2022 Oct 4, 2022
1920965
modified wave_4
Oct 4, 2022
ffe18db
Merge branch 'master' of https://github.com/mell2022/swap-meet
Oct 4, 2022
be3ef09
completed clothing, decor, elecronics, item, integration tests 1-3 p…
Oct 5, 2022
9cddf46
started wave_6 for vendor.py
Oct 5, 2022
32f10f8
All tests pass in wave 5.
mell2022 Oct 5, 2022
ec2327a
finished: clothing,decor,electronis child classes, vendor wave 5,all …
Oct 5, 2022
0378b22
pseudocode for both wave_6 methods, created helper_method to get best…
Oct 6, 2022
a63fd96
changed item condition dict to list, started wave6, unskipped tests w…
Oct 6, 2022
3ab563f
completed get_best_by_category wave 6, updated item.py, unskipped tes…
Oct 6, 2022
825392c
Part of wave 6 done
mell2022 Oct 6, 2022
d2cc000
modified wave 6: vendor method and test
Oct 6, 2022
c90149a
all unit tests and integration tests completed and pass, finished ven…
Oct 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions swap_meet/clothing.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,11 @@
class Clothing:
pass
from swap_meet.item import Item
class Clothing(Item):

# instantiate a class: this is where __init__ and attributes go
def __init__(self, condition=0):
super().__init__(category="Clothing", condition=condition)

def __str__(self):
return f"The finest clothing you could wear."


13 changes: 11 additions & 2 deletions swap_meet/decor.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,11 @@
class Decor:
pass
from swap_meet.item import Item
class Decor(Item):

def __init__(self, condition=0):
super().__init__(category="Decor", condition=condition)

def __str__(self):
return f"Something to decorate your space."



12 changes: 10 additions & 2 deletions swap_meet/electronics.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,10 @@
class Electronics:
pass
from swap_meet.item import Item
class Electronics(Item):

def __init__(self, condition=0):
super().__init__(category="Electronics", condition=condition)

def __str__(self):
return f"A gadget full of buttons and secrets."


19 changes: 18 additions & 1 deletion swap_meet/item.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,19 @@
class Item:
pass

def __init__(self, category="", condition=0):
self.category = category
self.condition = condition

def __str__(self):
return f"Hello World!"

def condition_description(self):
conditions = {
0: "You don't want this.",
1: "Anything is cheap enough.",
2: "It's OK.",
3: "No major issues.",
4: "Hardly worn and well taken care of.",
5: "Gonna go fast!"
}
return f"{conditions[self.condition]}"
77 changes: 76 additions & 1 deletion swap_meet/vendor.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,77 @@
from nis import cat


class Vendor:
pass
def __init__(self, inventory=None):
inventory = inventory if inventory is not None else []
self.inventory = inventory

def add(self, item):
self.inventory.append(item)
return item

def remove(self, item):
if item in self.inventory:
self.inventory.remove(item)
return item
else:
return False

def get_by_category(self, category=""):
items = []
for item in self.inventory:
if item.category == category:
items.append(item)

return items


def swap_items(self, vendor_friend, my_item, their_item):
if my_item not in self.inventory or their_item not in vendor_friend.inventory:
return False

self.inventory.remove(my_item)
vendor_friend.inventory.append(my_item)

vendor_friend.inventory.remove(their_item)
self.inventory.append(their_item)
return True

def swap_first_item(self, vendor_friend):
if self.inventory == [] or vendor_friend.inventory == []:
return False

my_first_item = self.inventory[0]
their_first_item = vendor_friend.inventory[0]

self.inventory.remove(my_first_item)
self.inventory.append(their_first_item)

vendor_friend.inventory.remove(their_first_item)
vendor_friend.inventory.append(my_first_item)

return True

# WAVE 6
def get_best_by_category(self, category):
list_of_items = self.get_by_category(category)
if not list_of_items:
return None
else:
best_item = max(list_of_items, key = lambda item: item.condition)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the lambda here!


return best_item

def swap_best_by_category(self, other, my_priority, their_priority):
if not self.inventory or not other.inventory:
return False

their_priority_item = other.get_best_by_category(my_priority)
if not their_priority_item:
return False

my_priority_item = self.get_best_by_category(their_priority)
if not my_priority_item:
return False

return self.swap_items(other, my_priority_item, their_priority_item)
2 changes: 1 addition & 1 deletion tests/integration_tests/test_wave_01_02_03.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from swap_meet.vendor import Vendor
from swap_meet.item import Item

@pytest.mark.skip
# @pytest.mark.skip
@pytest.mark.integration_test
def test_integration_wave_01_02_03():
# make a vendor
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/test_wave_04_05_06.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from swap_meet.decor import Decor
from swap_meet.electronics import Electronics

@pytest.mark.skip
# @pytest.mark.skip
@pytest.mark.integration_test
def test_integration_wave_04_05_06():
camila = Vendor()
Expand Down
13 changes: 7 additions & 6 deletions tests/unit_tests/test_wave_01.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
import pytest
from swap_meet.vendor import Vendor

@pytest.mark.skip
# @pytest.mark.skip
def test_vendor_has_inventory():
vendor = Vendor()
assert len(vendor.inventory) == 0

@pytest.mark.skip
# @pytest.mark.skip
def test_vendor_takes_optional_inventory():
inventory = ["a", "b", "c"]
vendor = Vendor(inventory=inventory)
Expand All @@ -16,7 +16,7 @@ def test_vendor_takes_optional_inventory():
assert "b" in vendor.inventory
assert "c" in vendor.inventory

@pytest.mark.skip
# @pytest.mark.skip
def test_adding_to_inventory():
vendor = Vendor()
item = "new item"
Expand All @@ -27,7 +27,7 @@ def test_adding_to_inventory():
assert item in vendor.inventory
assert result == item

@pytest.mark.skip
# @pytest.mark.skip
def test_removing_from_inventory_returns_item():
item = "item to remove"
vendor = Vendor(
Expand All @@ -40,7 +40,7 @@ def test_removing_from_inventory_returns_item():
assert item not in vendor.inventory
assert result == item

@pytest.mark.skip
# @pytest.mark.skip
def test_removing_not_found_is_false():
item = "item to remove"
vendor = Vendor(
Expand All @@ -49,7 +49,8 @@ def test_removing_not_found_is_false():

result = vendor.remove(item)

raise Exception("Complete this test according to comments below.")
# raise Exception("Complete this test according to comments below.")
# *********************************************************************
# ****** Complete Assert Portion of this test **********
# *********************************************************************
assert not result
9 changes: 5 additions & 4 deletions tests/unit_tests/test_wave_02.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
from swap_meet.vendor import Vendor
from swap_meet.item import Item

@pytest.mark.skip
# @pytest.mark.skip
def test_items_have_blank_default_category():
item = Item()
assert item.category == ""

@pytest.mark.skip
# @pytest.mark.skip
def test_get_items_by_category():
item_a = Item(category="clothing")
item_b = Item(category="electronics")
Expand All @@ -23,7 +23,7 @@ def test_get_items_by_category():
assert item_c in items
assert item_b not in items

@pytest.mark.skip
# @pytest.mark.skip
def test_get_no_matching_items_by_category():
item_a = Item(category="clothing")
item_b = Item(category="clothing")
Expand All @@ -34,7 +34,8 @@ def test_get_no_matching_items_by_category():

items = vendor.get_by_category("electronics")

raise Exception("Complete this test according to comments below.")
# raise Exception("Complete this test according to comments below.")
# *********************************************************************
# ****** Complete Assert Portion of this test **********
# *********************************************************************
assert len(items) == 0
13 changes: 7 additions & 6 deletions tests/unit_tests/test_wave_03.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
from unicodedata import category
import pytest
from swap_meet.vendor import Vendor
from swap_meet.item import Item

@pytest.mark.skip
#@pytest.mark.skip
def test_item_overrides_to_string():
item = Item()

stringified_item = str(item)

assert stringified_item == "Hello World!"

@pytest.mark.skip
#@pytest.mark.skip
def test_swap_items_returns_true():
item_a = Item(category="clothing")
item_b = Item(category="clothing")
Expand Down Expand Up @@ -38,7 +39,7 @@ def test_swap_items_returns_true():
assert item_b in jolie.inventory
assert result

@pytest.mark.skip
#@pytest.mark.skip
def test_swap_items_when_my_item_is_missing_returns_false():
item_a = Item(category="clothing")
item_b = Item(category="clothing")
Expand All @@ -65,7 +66,7 @@ def test_swap_items_when_my_item_is_missing_returns_false():
assert item_e in jolie.inventory
assert not result

@pytest.mark.skip
#@pytest.mark.skip
def test_swap_items_when_their_item_is_missing_returns_false():
item_a = Item(category="clothing")
item_b = Item(category="clothing")
Expand All @@ -92,7 +93,7 @@ def test_swap_items_when_their_item_is_missing_returns_false():
assert item_e in jolie.inventory
assert not result

@pytest.mark.skip
#@pytest.mark.skip
def test_swap_items_from_my_empty_returns_false():
fatimah = Vendor(
inventory=[]
Expand All @@ -112,7 +113,7 @@ def test_swap_items_from_my_empty_returns_false():
assert len(jolie.inventory) == 2
assert not result

@pytest.mark.skip
#@pytest.mark.skip
def test_swap_items_from_their_empty_returns_false():
item_a = Item(category="clothing")
item_b = Item(category="clothing")
Expand Down
6 changes: 3 additions & 3 deletions tests/unit_tests/test_wave_04.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from swap_meet.vendor import Vendor
from swap_meet.item import Item

@pytest.mark.skip
# @pytest.mark.skip
def test_swap_first_item_returns_true():
item_a = Item(category="clothing")
item_b = Item(category="clothing")
Expand Down Expand Up @@ -30,7 +30,7 @@ def test_swap_first_item_returns_true():
assert item_a in jolie.inventory
assert result

@pytest.mark.skip
# @pytest.mark.skip
def test_swap_first_item_from_my_empty_returns_false():
fatimah = Vendor(
inventory=[]
Expand All @@ -48,7 +48,7 @@ def test_swap_first_item_from_my_empty_returns_false():
assert len(jolie.inventory) == 2
assert not result

@pytest.mark.skip
# @pytest.mark.skip
def test_swap_first_item_from_their_empty_returns_false():
item_a = Item(category="clothing")
item_b = Item(category="clothing")
Expand Down
10 changes: 5 additions & 5 deletions tests/unit_tests/test_wave_05.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,25 @@
from swap_meet.decor import Decor
from swap_meet.electronics import Electronics

@pytest.mark.skip
# @pytest.mark.skip
def test_clothing_has_default_category_and_to_str():
cloth = Clothing()
assert cloth.category == "Clothing"
assert str(cloth) == "The finest clothing you could wear."

@pytest.mark.skip
# @pytest.mark.skip
def test_decor_has_default_category_and_to_str():
decor = Decor()
assert decor.category == "Decor"
assert str(decor) == "Something to decorate your space."

@pytest.mark.skip
# @pytest.mark.skip
def test_electronics_has_default_category_and_to_str():
electronics = Electronics()
assert electronics.category == "Electronics"
assert str(electronics) == "A gadget full of buttons and secrets."

@pytest.mark.skip
# @pytest.mark.skip
def test_items_have_condition_as_float():
items = [
Clothing(condition=3.5),
Expand All @@ -31,7 +31,7 @@ def test_items_have_condition_as_float():
for item in items:
assert item.condition == pytest.approx(3.5)

@pytest.mark.skip
# @pytest.mark.skip
def test_items_have_condition_descriptions_that_are_the_same_regardless_of_type():
items = [
Clothing(condition=5),
Expand Down
Loading