Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fontIconPicker #3431 #3522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

senn
Copy link
Contributor

@senn senn commented Feb 11, 2025

Should fix #3431

@senn senn force-pushed the bugfix/fix-fonticon-error branch from 987ca68 to 79d6c55 Compare February 11, 2025 14:44
Copy link

github-actions bot commented Feb 11, 2025

Test Results

 2 970 files  ±0   2 970 suites  ±0   1h 46m 40s ⏱️ + 12m 45s
 1 890 tests ±0   1 890 ✅ ±0  0 💤 ±0  0 ❌ ±0 
17 010 runs  ±0  17 001 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit fbaf677. ± Comparison against base commit 6932178.

♻️ This comment has been updated with latest results.

@kwin
Copy link
Contributor

kwin commented Feb 12, 2025

@senn Thanks for the PR, can you add a changelog entry?

@senn senn force-pushed the bugfix/fix-fonticon-error branch from 79d6c55 to 3d57b71 Compare February 12, 2025 08:06
@senn
Copy link
Contributor Author

senn commented Feb 12, 2025

done

@senn senn force-pushed the bugfix/fix-fonticon-error branch from 3d57b71 to b970496 Compare February 12, 2025 08:09
Co-authored-by: Konrad Windszus <[email protected]>
@senn
Copy link
Contributor Author

senn commented Feb 24, 2025

@kwin any chance of a merge and fix-release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue on aem cloud author | fontIconPicker is not a function
2 participants