Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add giot.switch.v62ksm and lemesh.remote.ts00 #1561

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

maxmib
Copy link
Contributor

@maxmib maxmib commented Feb 4, 2025

Add SmartFrog V6 Double Wall Switch and LeMesh Scene Wireless Button S

@AlexxIT
Copy link
Owner

AlexxIT commented Feb 5, 2025

Thanks. That's better. But there are still mistakes:

  • action can be one, and you can use value=BUTTON_1_SINGLE and BUTTON_2_SINGLE
  • In the second device, you use BUTTON_1_SINGLE. Although there is only one button. BUTTON_SINGLE will be better.

@maxmib
Copy link
Contributor Author

maxmib commented Feb 5, 2025

I made some changes as you suggested,I think it's ok to merge now.

@AlexxIT
Copy link
Owner

AlexxIT commented Feb 6, 2025

Sorry for bothering you again. But not switch_action, just action.
It is important that all converters are as similar as possible. To make it more convenient for users to write similar automations.

@maxmib
Copy link
Contributor Author

maxmib commented Feb 6, 2025

I modified the code. Please check it .

@AlexxIT AlexxIT merged commit 100d4d7 into AlexxIT:master Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants