Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added longest prefix suffix problem #783

Merged
merged 14 commits into from
May 18, 2021

Conversation

ansi22-zz
Copy link
Contributor

Hey,

@anubhavitis @dheerajkotwani @tarun26091999 @todi-2000 @geekquad @plazzy99 @rudrakshi99
Kindly check this out it will fix issue #499 ,i.e, longest prefix suffix problem.
Thankyou!

Copy link
Member

@tarun26091999 tarun26091999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is fine. Add some more comments explaining your steps. Also space complexity is wrong. Give proper indentation and link it to the correct folder. remove line 9.

@ansi22-zz
Copy link
Contributor Author

@tarun26091999 kindly check it out, I have made the changes.

@ghost
Copy link

ghost commented Mar 17, 2021

I WANT TO CONTRIBUTE

Copy link
Member

@tarun26091999 tarun26091999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you haven't linked it to the folder yet.

@ansi22-zz
Copy link
Contributor Author

@tarun26091999 Sir, I have linked the file in string folder under branch issue-499, is it not showing there. Please tell how should I proceed.

@ansi22-zz
Copy link
Contributor Author

@tarun26091999 Sir kindly review this.

@ansi22-zz
Copy link
Contributor Author

@rish-singhal can you please review it.

Copy link
Member

@tarun26091999 tarun26091999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve the conflict.

@ansi22-zz
Copy link
Contributor Author

I have resolved the conflict @tarun26091999 kindly look into it.

@tarun26091999
Copy link
Member

@ansi22 make correct indentations

@tarun26091999 tarun26091999 merged commit cd47a05 into Algo-Phantoms:main May 18, 2021
@ansi22-zz
Copy link
Contributor Author

@tarun26091999 please once go through #899, scores for it didn't get updated 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants