Add test on language model settings page #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlindsey
force-pushed
the
check-connection
branch
from
a3ae7de to
e887c05
Compare
krschacht
requested changes
Dec 20, 2024
There was a problem hiding this comment.
The code for this looks great. I tested this out locally and made some small tweaks the aesthetic of it, but functionally it's working well. Two questions:
- When I removed the API key for a service (pretending like I left it off) and then I clicked "test" I got an exception. Can we fail more gracefully so the user sees a nice red error message next to the "Test" link?
- Should we also add a Test link when editing the API Services or is that tricky because we don't know a model name?
mattlindsey
force-pushed
the
check-connection
branch
from
718994d to
37fae04
Compare
|
Nice improvements! I'm merging this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test link and green message on success, red on error.
If this looks ok, I can also add a test link on the API Service settings page as shown here: #436
I tested this PR on my setup with Anthropic, OpenAI, Gemini, Groq, and Ollama.
I think I need to add tests for the new
testcontroller action. And probably the model and service too.