feat(resource-adm): move access package list into accordion to shrink policy rule height

[mgunnerud]

Description

Feedback from Skatteetaten: hide access packages list in policy rules by default

Related Issue(s)

• Hide/minify access package list in policy rules editor #14623

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

• New Features

  • Introduced a collapsible section to group access package selection elements for a more organized interface.
  • Added a new user-facing message: "Vis alle tilgangspakker" to enhance localization for the policy editor.

• Bug Fixes

  • Adjusted text punctuation in messages to ensure proper display.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR introduces a new entry in the Norwegian localization file by adding the key "policy_editor.access_package_accordion_header" with the value "Vis alle tilgangspakker". Additionally, the PolicyAccessPackages component is refactored to incorporate an Accordion structure, organizing several UI sub-components without altering the underlying functionality.

Changes

File	Change Summary
frontend/language/src/nb.json	Added "policy_editor.access_package_accordion_header": "Vis alle tilgangspakker".
frontend/packages/policy-editor/src/components/PolicyCardRules/...	Introduced an Accordion to encapsulate PolicyAccessPackages sub-components (PolicyAccessPackagesWarning, StudioLabelAsParagraph, StudioTextfield, AllAccessPackages).

Possibly related PRs

• fix: updated text #14634: The changes in the main PR, which add a new entry to the nb.json file, are related to the modifications in the retrieved PR that also involve updates to the same nb.json file, specifically enhancing text clarity and correctness.
• chore: reorganize summary2 translation keys #14406: The changes in the main PR, which add a new localization key in frontend/language/src/nb.json, are related to the modifications in the retrieved PR that also involve changes to the same JSON file, specifically the addition and restructuring of translation keys.

Suggested labels

area/ui-editor, text/content

Suggested reviewers

• Jondyr
• lassopicasso

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5115c5c and fa9ac26.

📒 Files selected for processing (1)

• frontend/language/src/nb.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• frontend/language/src/nb.json

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (f2a6c5c) to head (fa9ac26).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14626   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files        1914     1914           
  Lines       24947    24948    +1     
  Branches     2855     2855           
=======================================
+ Hits        23890    23891    +1     
  Misses        799      799           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackages.tsx (1)

86-114: Great implementation with room for accessibility improvements!

The Accordion implementation effectively achieves the goal of reducing policy rule height while maintaining all functionality. Consider these accessibility enhancements:

-      <Accordion>
+      <Accordion aria-label={t('policy_editor.access_package_header')}>

Also, consider if the accordion should be open by default based on UX requirements:

-      <Accordion>
+      <Accordion defaultOpen={false}>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecd1df9 and 6018a17.

📒 Files selected for processing (2)

• frontend/language/src/nb.json (2 hunks)
• frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackages.tsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• frontend/language/src/nb.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build environment and run e2e test

🔇 Additional comments (1)

frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackages.tsx (1)

16-16: LGTM!

Clean import of the Accordion component from the design system package.