Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add correspondenceservice as resource type in regestry #14671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Andreass2
Copy link

@Andreass2 Andreass2 commented Feb 14, 2025

Description

  • Adds correspondence as a resource in the registry

Related Issue(s)

Issue in Correspondence

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • New Features
    • Introduced a new resource type option, "Correspondence Service", to broaden resource selection.
    • Updated the language support so that this type is displayed as "Meldingstjeneste" for improved clarity.

Copy link
Contributor

coderabbitai bot commented Feb 14, 2025

📝 Walkthrough

Walkthrough

This pull request introduces the new resource type option "CorrespondenceService" across several parts of the application. The changes update the type definition, the mapping of resource types, and the associated language translation. This ensures that correspondence services can be consistently recognized and handled within the system without altering any existing functionality.

Changes

Files Change Summary
frontend/.../ResourceAdm.ts
frontend/.../resourceUtils.ts
Added "CorrespondenceService" to the union type (ResourceTypeOption) and to the resourceTypeMap, expanding the supported resource types.
frontend/resourceadm/language/src/nb.json Introduced a new translation entry for "resourceadm.about_resource_resource_type_correspondenceservice" with the value "Meldingstjeneste", and applied a newline for formatting.

Possibly related PRs

Suggested labels

solution/studio/designer, area/content-library, frontend, team/studio-domain1, skip-manual-testing, skip-documentation

Suggested reviewers

  • wrt95
  • github-actions

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8255827 and 6d6f2c2.

📒 Files selected for processing (3)
  • frontend/packages/shared/src/types/ResourceAdm.ts (1 hunks)
  • frontend/resourceadm/language/src/nb.json (2 hunks)
  • frontend/resourceadm/utils/resourceUtils/resourceUtils.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build environment and run e2e test
  • GitHub Check: Build environment and run e2e test
🔇 Additional comments (3)
frontend/packages/shared/src/types/ResourceAdm.ts (1)

38-43: LGTM! Clean addition of the new resource type.

The addition of 'CorrespondenceService' to the ResourceTypeOption type is well-integrated and consistent with the existing type system.

frontend/resourceadm/utils/resourceUtils/resourceUtils.ts (1)

19-24: LGTM! Resource type mapping properly added.

The mapping for 'CorrespondenceService' follows the established pattern and correctly links to its translation key.

frontend/resourceadm/language/src/nb.json (1)

67-67: LGTM! Translation properly added.

The Norwegian Bokmål translation "Meldingstjeneste" is correctly added with the matching translation key.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Feb 14, 2025
@Andreass2 Andreass2 changed the title add correspondenceservice as resource type in regestry feat:add correspondenceservice as resource type in regestry Feb 14, 2025
@Andreass2 Andreass2 changed the title feat:add correspondenceservice as resource type in regestry feat: add correspondenceservice as resource type in regestry Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant