Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kick players who send too long messages #10536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

squi2rel
Copy link
Contributor

@squi2rel squi2rel commented Mar 7, 2025

Error stacktraces are too annoying

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

Error stacktraces are too annoying
@JasonP01
Copy link
Contributor

JasonP01 commented Mar 7, 2025

LMFAO i vote no its too funny to the server owner sending a string of 99999 "h"

Either way you could make a handler for the error, kicking the player is less than ideal when besides foul play they dont know they do it.

Regular chat textboxes dont even allow more than 150 characters anyway

@JasonP01
Copy link
Contributor

JasonP01 commented Mar 7, 2025

30s is not excessive but it is long, still think catching the error for no stacktrace would be better - as a player

@squi2rel
Copy link
Contributor Author

squi2rel commented Mar 7, 2025

30s is not excessive but it is long, still think catching the error for no stacktrace would be better - as a player

No. It's illegal to send such a long message, it's a waste of bandwidth and storage.

@JasonP01
Copy link
Contributor

JasonP01 commented Mar 7, 2025

Its not that deep fam

@BnDLett
Copy link
Contributor

BnDLett commented Mar 7, 2025

30s is not excessive but it is long, still think catching the error for no stacktrace would be better - as a player

No. It's illegal to send such a long message, it's a waste of bandwidth and storage.

ong. I can't spare ~100 KB. 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants