Check for unit constructor validity #10543
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sanity checks in
UnitType
'sconstructor
:constructor == null
, point them to common Vanilla unit classes.constructor != null
butEntityMapping.map(name)
returnsnull
, register the unit type's name tonameMap
.idMap[constructor.classId()] == null
, throw an exception.constructor.classId() != idMap[constructor.classId()].get().classId()
, throw an exception.PR preliminary checks