Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nvim-dap-repl-highlights): nvim-dap in dependencies breaks lazy loading #1412

Closed
wants to merge 1 commit into from

Conversation

RayJameson
Copy link
Contributor

@RayJameson RayJameson commented Apr 1, 2025

📑 Description

nvim-dap in dependencies breaks lazy loading of the nvim-dap plugin and all related plugins

ℹ Additional Information

before this patch dap* plugins loaded on nvim open:
image

Copy link

github-actions bot commented Apr 1, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Sorry, something went wrong.

@RayJameson
Copy link
Contributor Author

this PR is wrong, it seems the reason for breaking lazy loading is my own config...

@RayJameson RayJameson closed this Apr 2, 2025
@RayJameson
Copy link
Contributor Author

No it wasn't ...
I just removed opts = {} from dap-repl config, which caused break it, but nvim-dap in dependencies is still breaking the lazy loading, so this time it should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant