189: improve event edition

- add "rows" attribute to the text area - remove annoying max and min attribute contraints
Atmos4 · Apr 10, 2024 · c67db93 · c67db93
1 parent 6d4c29e
commit c67db93
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/app/pages/events/event_edit.php b/app/pages/events/event_edit.php
@@ -66,7 +66,7 @@
                 <?= $limit_date->render() ?>
             </div>
             <?= $bulletin_url->render() ?>
-            <?= $description->render() ?>
+            <?= $description->attributes(["rows" => "8"])->render() ?>
         </div>
     </article>
 </form>
diff --git a/engine/validation/fields.php b/engine/validation/fields.php
@@ -279,19 +279,17 @@ function check(string $msg = null)
     }
 
     /** Set upper date limit */
-    function max(string|null $date, string $msg = null, bool $addAttribute = true)
+    function max(string|null $date, string $msg = null)
     {
-        $addAttribute ? $this->attributes(["max" => $date ?? ""]) : null;
         if ($this->should_test() && $date && strtotime($this->value) > strtotime($date)) {
             $this->set_error($msg ?? "Trop tard");
         }
         return $this;
     }
 
     /** Set lower date limit */
-    function min(string|null $date, string $msg = null, bool $addAttribute = true)
+    function min(string|null $date, string $msg = null)
     {
-        $addAttribute ? $this->attributes(["min" => $date ?? ""]) : null;
         if ($this->should_test() && $date && strtotime($this->value) < strtotime($date)) {
             $this->set_error($msg ?? "Trop tôt");
         }
@@ -365,12 +363,14 @@ class UploadField extends Field
             'image/jp2',
             'image/heif'
         ],
-        'doc' => ['application/msword',
+        'doc' => [
+            'application/msword',
             'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
             'application/vnd.ms-word.document.macroEnabled.12',
             'application/vnd.openxmlformats-officedocument.wordprocessingml.template',
             'application/vnd.ms-word.template.macroEnabled.12',
-            'application/vnd.oasis.opendocument.text',],
+            'application/vnd.oasis.opendocument.text',
+        ],
         'pdf' => ['application/pdf'],
         'excel' => [
             'application/vnd.ms-excel',