Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add future and past event lists #170

Merged
merged 9 commits into from
Mar 10, 2024
Merged

Add future and past event lists #170

merged 9 commits into from
Mar 10, 2024

Conversation

Mathieu414
Copy link
Collaborator

Adding accordions to the event page in order to have a better understanding between past and future events. The idea is to organise a bit.

@Mathieu414
Copy link
Collaborator Author

Some new changes - tried to isolate the past events rendering using htmx. Seems to be working, but had some problems with the router. I had to make a small change to have to possibility to be able to get clean html code when requesting some page elements using htmx.
Also added a small fix to a download bug, not a big deal so I included it in this PR, although that's not super clean.

Copy link
Owner

@Atmos4 Atmos4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, I don't really like this new article design for event list. You need to convince me :)

Edit: I am convinced! 😊

Mathieu414 and others added 2 commits March 7, 2024 12:53
- rename toast test page
- fix deprecated code in `event_edit`
- add extra gap below birthdays
- fix formatting of past events
- remove dead code in `RenderEvents`
- fix `event_list` CSS
- improve typings in `FactoryDependency`
@Mathieu414 Mathieu414 merged commit 1de78ea into master Mar 10, 2024
1 check passed
@Mathieu414 Mathieu414 deleted the 169-organise-old-events branch March 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants