Add club parameters page #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
About the ability to add a feature to the whole club, I'm not sure if you need to put it here. Should the admin of the club be able to decide if they add features or not ? |
Atmos4
reviewed
Feb 2, 2025
Atmos4
reviewed
Feb 8, 2025
There was a problem hiding this comment.
To speed up the process, maybe you could also review your changes to speed up the review process. There are things here that can be resolved earlier just by looking at the diff.
Overall ok, but now that I looked at it a bit more, I can see that there are some things I would want you to fix before merging.
Atmos4
approved these changes
Feb 8, 2025
Mathieu414
added a commit
that referenced
this pull request
Feb 25, 2025
* Fix download files bug (#378) * 377: fix download files * 377: fix permission level * Add club parameters page (#375) * 373: add club parameters page * 373: fix broken doctrine command * 373: Add club features * 373: reduce singleton use * 373: fix club features * 373: review change * 373: fix small bug on featureService * Add link page and jotform (#380) * 376: Add link page and jotform * 376: review changes * Groups (#382) * 381: Add groups * 381: review changes * Various improvements (#386) - fix some code formatting issues - improve code readability with management tool - add zip mime type for supported types --------- Co-authored-by: Mathieu Perrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some new features to the db to make it easier to set up the google calendar connection. Even though I am a bit unsure about how this will be used.
Anyways, I really believe this new club settings page can be useful.
@Atmos4 any ideas what else could be interesting to add on this page ?