Plate Accessory Stuff #19903
Open
Plate Accessory Stuff #19903
+76
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Geevies
commented
Sep 15, 2024
Geevies
commented
- You can now ctrl+click on any worn clothing item that has accessories attached to quickly open the accessory removal radial menu.
- Removing accessories with the radial accessory removal menu will now reopen that menu until either all the accessories are removed, or you click the close button.
- Plate Carrier armor accessories will now always render below other accessories, so you don't need to shuffle everything to layer them correctly.
|
!review |
NonQueueingMatt
approved these changes
Nov 4, 2024
| var/mob/living/M = usr | ||
| remove_accessory_handler(usr) | ||
|
|
||
| /obj/item/clothing/proc/remove_accessory_handler(var/mob/living/user, var/force_radial = FALSE) |
| var/list/new_accessory_list = list() | ||
| var/list/accessories_by_layer = list() | ||
|
|
||
| for(var/i = ACCESSORY_LOWEST_LAYER, i <= ACCESSORY_HIGHEST_LAYER, i++) |
There was a problem hiding this comment.
Suggested change
| for(var/i = ACCESSORY_LOWEST_LAYER, i <= ACCESSORY_HIGHEST_LAYER, i++) | |
| for(var/i in ACCESSORY_LOWEST_LAYER to ACCESSORY_HIGHEST_LAYER) |
| for(var/obj/item/clothing/accessory/accessory as anything in accessories) | ||
| accessories_by_layer["[accessory.accessory_layer]"] += accessory | ||
|
|
||
| for(var/i = ACCESSORY_LOWEST_LAYER, i <= ACCESSORY_HIGHEST_LAYER, i++) |
There was a problem hiding this comment.
Suggested change
| for(var/i = ACCESSORY_LOWEST_LAYER, i <= ACCESSORY_HIGHEST_LAYER, i++) | |
| for(var/i in ACCESSORY_LOWEST_LAYER to ACCESSORY_HIGHEST_LAYER) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.