Refactors cargo to reside in the codebase #20030
Open
+7,674
−561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nauticall
requested review from
Arrow768,
JohnWildkins and
NonQueueingMatt
as code owners
nauticall
added
Test Merge Candidate
|
!review |
Co-authored-by: Fluffy <[email protected]> Signed-off-by: naut <[email protected]>
code/modules/modular_computers/file_system/programs/civilian/cargo_order.dm
Outdated
Show resolved
Hide resolved
code/modules/modular_computers/file_system/programs/civilian/cargo_order.dm
Outdated
Show resolved
Hide resolved
FluffyGhoster
approved these changes
Oct 16, 2024
Arrow768
added
the
⛔ Maintainer Discussion
|
MD to determine if we should deviate from the established position that cargo data is stored in the db |
Geevies
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE TO SYSADMINS: This PR makes the Cargo SQL file(s) stored online redundant. They should be removed.
Moves the data containing cargo items (i.e. the ones you order from ops and get in the cargo shuttle) from the online database to the codebase. Everything from suppliers to categories to individual items is now code-side and editable by developers/contributors.
Refactors cargo items to use
singletonsinstead ofdatumsforcargo_supplier,cargo_category, andcargo_item. Multiple-instnace things like cargo_orders, etc. still usedatums.Fixed a bunch of strange discrepancies in categories, suppliers, and pricing for various cargo items. I did a little bit, but it's exhausting to go through all of it right now.
Clicking the 'Details' button on the Cargo Order app now actually gives you details instead of bluescreening. Also added some UI elements to the Cargo Order app - Cargo Control and Delivery remain untouched.
Overhauled the Cargo Order console TGUI window. It now has tabs on the left, displays restricted access, supplier information, and boasts search functionality.
This PR has a lot of moving parts, and would probably be best suited for a testmerge to iron out any possible hiccups.