Skip to content

Commit

Permalink
Merge pull request #61 from AutoIDM/90day_default
Browse files Browse the repository at this point in the history
Go back 90 days and bump version
  • Loading branch information
visch authored Sep 21, 2023
2 parents 7033a4a + 8427246 commit 4f04fe1
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ THIS IS NOT READY FOR PRODUCTION. Bearer tokens sometimes slip out to logs. Use
| refresh_token | True | None | Refresh Token from Oauth dance |
| customer_id | True | None | Customer ID from Google Ads Console, note this should be the top level client. This tap will pull all subaccounts |
| login_customer_id| True | None | Customer ID that has access to the customer_id, note that they can be the same, but they don't have to be as this could be a Manager account |
| start_date | True | 2022-03-24T00:00:00Z (Today-7d) | Date to start our search from, applies to Streams where there is a filter date. Note that Google responds to Data in buckets of 1 Day increments |
| start_date | True | 2022-03-24T00:00:00Z (Today-90d) | Date to start our search from, applies to Streams where there is a filter date. Note that Google responds to Data in buckets of 1 Day increments |
| end_date | True | 2022-03-31T00:00:00Z (Today) | Date to end our search on, applies to Streams where there is a filter date. Note that the query is BETWEEN start_date AND end_date |

Note that although customer IDs are often displayed in the Google Ads UI in the format 123-456-7890, they should be provided to the tap in the format 1234567890, with no dashes.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "tap-googleads"
version = "0.1.6"
version = "0.1.7"
description = "`tap-googleads` is a Singer tap for GoogleAds, built with the Meltano SDK for Singer Taps."
authors = ["AutoIDM"]
keywords = [
Expand Down
18 changes: 9 additions & 9 deletions tap_googleads/tap.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
"""GoogleAds tap class."""

from datetime import date, timedelta
from typing import List

from singer_sdk import Tap, Stream
from singer_sdk import Stream, Tap
from singer_sdk import typing as th # JSON schema typing helpers
from datetime import date, timedelta

from tap_googleads.streams import (
CampaignsStream,
AdGroupsStream,
AdGroupsPerformance,
AccessibleCustomers,
CustomerHierarchyStream,
AdGroupsPerformance,
AdGroupsStream,
CampaignLabel,
CampaignPerformance,
CampaignPerformanceByAgeRangeAndDevice,
CampaignPerformanceByGenderAndDevice,
CampaignPerformanceByLocation,
GeotargetsStream,
CampaignsStream,
ConversionsByLocation,
CampaignLabel,
CustomerHierarchyStream,
GeotargetsStream,
)

STREAM_TYPES = [
Expand Down Expand Up @@ -89,7 +89,7 @@ class TapGoogleAds(Tap):
th.Property(
"start_date",
th.DateTimeType,
default=(date.today() - timedelta(days=7)).strftime("%Y-%m-%dT%H:%M:%SZ"),
default=(date.today() - timedelta(days=90)).strftime("%Y-%m-%dT%H:%M:%SZ"),
required=True,
description=(
"Date to start our search from, applies to Streams where there is a "
Expand Down

0 comments on commit 4f04fe1

Please sign in to comment.