Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export more hovercards status methods #70

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Export more hovercards status methods #70

merged 2 commits into from
Aug 20, 2024

Conversation

wellyshen
Copy link
Contributor

@wellyshen wellyshen commented Aug 20, 2024 •
edited
Loading

Related to 108684-gh-Automattic/gravatar

Proposed Changes

  • Export createHovercardSkeleton and its relevant types
  • Export createHovercardError and its relevant types
  • Update the relevant docs
  • (extra) Export CreateHovercardOptions type
  • (extra) Adjust husky's pre-commit script
  • (extra) Fix lint-staged script

Testing Instructions

  • Check out this PR
  • cd web/packages/hovercards
  • npm run build:watch
  • Open another terminal, and npm run start
  • Check the following section of the playground, all the hovercards should work as expected:
截圖 2024-08-20 下午4 55 39

@wellyshen wellyshen self-assigned this Aug 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Size Change: +629 B (+2.15%)

Total Size: 29.9 kB

Filename Size Change
dist/index.esm.js 6.36 kB +174 B (+2.81%)
dist/index.js 6.51 kB +175 B (+2.76%)
dist/index.react.js 8.43 kB +173 B (+2.1%)
dist/index.react.umd.js 4.77 kB +52 B (+1.1%)
dist/index.umd.js 3.84 kB +55 B (+1.45%)

compressed-size-action

aaronfc
aaronfc approved these changes Aug 20, 2024
View reviewed changes
Copy link

@aaronfc aaronfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well!

Thanks :)

@wellyshen wellyshen merged commit 6ed14f2 into trunk Aug 20, 2024
2 checks passed
@wellyshen wellyshen deleted the export-hovercards-status-methods branch August 20, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfc aaronfc aaronfc approved these changes

@johngodley johngodley Awaiting requested review from johngodley

Assignees

@wellyshen wellyshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wellyshen @aaronfc