Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not display hidden verified accounts #88

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

wellyshen
Copy link
Contributor

@wellyshen wellyshen commented Sep 18, 2024

Related to this GH issue: 108896-gh-Automattic/gravatar

Proposed Changes

  • Don't display hidden verified accounts

Testing Instructions

  • Check out to this PR
  • cd web/packages/hovercards
  • Run npm run build:watch
  • Open another terminal, and run npm run start
  • Modify the playground to use your Gravatar identity
  • Go to: https://gravatar.com/profile/verified-accounts, and try to show / hide the verified accounts
  • The hidden accounts won't be displayed

@wellyshen wellyshen self-assigned this Sep 18, 2024
Copy link

Size Change: +121 B (+0.4%)

Total Size: 30 kB

Filename Size Change
dist/index.esm.js 6.39 kB +30 B (+0.47%)
dist/index.js 6.54 kB +30 B (+0.46%)
dist/index.react.js 8.46 kB +30 B (+0.36%)
dist/index.react.umd.js 4.78 kB +16 B (+0.34%)
dist/index.umd.js 3.86 kB +15 B (+0.39%)

compressed-size-action

Copy link

@lamosty lamosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@@ -419,6 +423,7 @@ export default class Hovercards {
label: account.service_label,
icon: account.service_icon,
url: account.url,
isHidden: account.is_hidden,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always be present on account?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has replied on the relevant Slack thread.

@wellyshen wellyshen merged commit 75eb985 into trunk Sep 18, 2024
2 checks passed
@wellyshen wellyshen deleted the fix/do-not-show-hidden-verified-accounts branch September 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants