Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's New Section: Add menu item to trigger the modal manually #1129

Merged
merged 11 commits into from
Mar 26, 2025

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Mar 25, 2025

Related issues

  • Resolves STU-227-linear-issue.

Proposed Changes

  • add "What's New" menu item to the top app menu, hidden behind the feature flag

Markup on 2025-03-26 at 10:45:14

Testing Instructions

  1. Check out the PR branch and build the app with STUDIO_WHATS_NEW_SECTION=true npm start.
  2. Head over to the Help menu at the top. There should be a new What's New menu item.
  3. If you click it, a temporary modal should open.
  4. If the app is build with npm start, there should be no new menu item.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ivan-ottinger ivan-ottinger self-assigned this Mar 26, 2025
@ivan-ottinger ivan-ottinger force-pushed the add/whats-new-modal-menu-item branch from 4b6de61 to ed80903 Compare March 26, 2025 09:40
@ivan-ottinger ivan-ottinger marked this pull request as ready for review March 26, 2025 10:04
@ivan-ottinger ivan-ottinger changed the title Add/whats new modal menu item Add What's New modal menu item Mar 26, 2025
@ivan-ottinger ivan-ottinger changed the title Add What's New modal menu item What's New Section: Add menu item to trigger the modal manually Mar 26, 2025
@ivan-ottinger ivan-ottinger requested a review from a team March 26, 2025 10:08
@ivan-ottinger ivan-ottinger mentioned this pull request Mar 26, 2025
1 task
Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and work as expected on my end. If you could please merge this into trunk, we can then integrate this with #1128

@ivan-ottinger ivan-ottinger merged commit 0cdb067 into trunk Mar 26, 2025
10 checks passed
@ivan-ottinger ivan-ottinger deleted the add/whats-new-modal-menu-item branch March 26, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants