Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - multi worker poc #979

Draft
wants to merge 27 commits into
base: trunk
Choose a base branch
from
Draft

wip - multi worker poc #979

wants to merge 27 commits into from

Conversation

ashfame
Copy link
Member

@ashfame ashfame commented Feb 25, 2025

Related issues

  • Fixes #

Proposed Changes

Testing Instructions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ashfame ashfame changed the title wip wip - multi worker poc Feb 25, 2025
@brandonpayton
Copy link
Member

@ashfame I spent a little time reading over these changes and haven't noticed anything specific to call out in the code.

IIRC, you mentioned earlier that performance seemed about the same as a single worker. If we can confirm that multiple processes are indeed handling requests, I am wondering a few things:

  • Could this have anything to do with the express server?
    • How does its HTTP version compare with the faster reference points (like the Pressable example here)
    • Is it handling connections differently than Pressable (WP Cloud)? For example, are HTTP connections being reused or kept open or just per-request?
  • Does profiling the main process show us anything?
  • Would message passing between multiple workers(instead of processes) be any faster? Intuitively, working between multiple threads in one process seems like it should be faster than requiring the OS to coordinate multiple processes.
    NOTE: If we switch to multiple workers, would we learn more from profiling because we'd be profiling all activity for a given server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants