Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy over nonce from parsed POST vars to parsed GET vars as a temp fix #36

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Copy over nonce from parsed POST vars to parsed GET vars as a temp fix #36

merged 6 commits into from
Sep 23, 2022

Commits on Sep 21, 2022

  1. switch to GET method when taking user consent 

    Currently bshaffer oauth library has a bug when POST is used on AuthorizeEndpoint along with nonce
(optional parameter) which fails to set the nonce in id_token
    @ashfame
    ashfame committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    ebd4033 View commit details
    Browse the repository at this point in the history

  2. suppress phpcs warning since its irrelevant in this case

    @ashfame
    ashfame committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    5ec0967 View commit details
    Browse the repository at this point in the history

  3. separate explanation for phpcs:disable by --

    @ashfame
    ashfame committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    1ca02bc View commit details
    Browse the repository at this point in the history

  4. Revert changes in this PR for different approach 

        This reverts commit 1ca02bc.
    This reverts commit 5ec0967.
    This reverts commit ebd4033.
    @ashfame
    ashfame committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    f0b158a View commit details
    Browse the repository at this point in the history

  5. copy over the nonce from parsed POST parameters to parsed GET paramet… 

    …ers in $request object as a temporary fix
    @ashfame
    ashfame committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    7d090a2 View commit details
    Browse the repository at this point in the history

  6. reformat comment to satisfy linter

    @ashfame
    ashfame committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    d061d40 View commit details
    Browse the repository at this point in the history