Remove margin around TextEditor #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most code editors have a margin on the line number panel to make it more readable and prettier. Removing the margin feels much worse to me. |
|
@Rekkonnect Thanks for the feedback. I was mainly worried about the margins on the other sides. Having space between the scrollbars and the window, felt like a bug. I pushed a small change. Keep some margin on the left for readability, remove the top/right/bottom margins. Here is what it looks like:
|
Increase the size of the LineNumberMargin to improve readability and ensure that there is some space between the line numbers and the next AbstractMargin.
mgarstenauer
force-pushed
the
remove-margin-around-texteditor
branch
from
35b1b41
to
bbd2e65
Compare
|
I increased the minimum size of the Together with the breakpoint margin it looks like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cosmetic PR that removes the 30px margin around the
TextEditorin the demo.Before:
After:
(Looking at the git history, the
Marginhas been there for the last 7+ years. I don't think that the margin serves any purpose. Let's remove it to avoid any confusion!)