Set selected filter initially to all to match picker option #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiOelfke
requested review from
jordibruin,
AvdLee and
hiddevdploeg
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status filter picker is initialized with an empty string "" currently, but this is not an option in the picker. So SwiftUI complains with a fault log:
Picker: the selection "" is invalid and does not have an associated tag, this will give undefined results.
This PR initializes this with "all", which is always available. Other ways could be to just default the State to "all" and to remove the argument from the auto generated init. Or make it user configurable. But I don't have time for this so this is a quick fix.