CSS modifications #60
Conversation
|
@AdityaSrivast Please review my PR. Please let me know if I have to improve anything. |
test-server/package.json
Outdated
| @@ -8,6 +8,7 @@ | |||
| "@testing-library/user-event": "^7.1.2", | |||
| "react": "^16.13.0", | |||
| "react-dom": "^16.13.0", | |||
| "react-pincode": "^1.0.2", | |||
There was a problem hiding this comment.
@Rukmini-Meda there's no need to install the module in the test directory. Get rid of this line.
| @@ -10,10 +15,43 @@ input::-webkit-inner-spin-button { | |||
|
|
|||
| /* Firefox */ | |||
| input[type=number] { | |||
| -moz-appearance: textfield; | |||
| /* -moz-appearance: textfield; */ | |||
There was a problem hiding this comment.
@Rukmini-Meda any reason why this line is commented?
|
@AdityaSrivast I made changes as you said. I removed the package-lock.json file, removed the line you said in package.json. And about the line that's commented, when I started to implement my styling I kinda commented it to check what I was doing. Its completely fine even if its not commented. Please review for any more changes and merge. Thank you! |
|
@AdityaSrivast Can you merge this PR if there are no other changes or improvements required? |
|
@Rukmini-Meda get rid of |
|
@AdityaSrivast Sure, I will update it by tomorrow. |
|
@AdityaSrivast Can you help me with codesandbox? I imported my branch into it. But build/index.js shows many problems although it works fine in vscode. This is the link for codesandbox - https://codesandbox.io/s/distracted-yonath-6l27d?file=/build/index.js:0-26767 |
@AdityaSrivast Can you help with this so that the PR can be merged as we have only 2 days left? |
There was a problem hiding this comment.
@Rukmini-Meda If it is working fine in vs-code then you must've done some mistake in implementing it in Code Sandbox. I reviewed it and was able to solve around 50 errors just by formatting it properly. Try implementing it again using some proper guide.
|
@yellowwoods12 Can you suggest any resources? |
|
@yellowwoods12 @AdityaSrivast Can you please help me with codesandbox so that I can complete this PR successfully? |
|
@Rukmini-Meda use Resolve conflicts and make the changes which I asked previously and we'll merge it through. 👍 |
Fixes #4
Changes done in this pull request:
Changed styling of the input fields
Files Added:
No new files added or removed.
index.js and App.css files changed
Screenshots/Links:
System Information :
Reviewers:
@AdityaSrivast Please review my PR. I made style changes for input fields and error dialog. Please let me know if I have to make any more further changes or improvements.