Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**Fix Typos in graph.cpp and client_ivc.test.cpp** #1185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

**Fix Typos in graph.cpp and client_ivc.test.cpp** #1185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48ea57c
typo fix graph.cpp
Dec 31, 2024
6fda47d
typo fix client_ivc.test.cpp
Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/src/barretenberg/boomerang_value_detection/graph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ bool Graph_<FF>::check_is_not_constant_variable(bb::UltraCircuitBuilder& ultra_c
}

/**
* @brief this method adds connection between 2 variables, if they are in one gate, they are not constrant variables,
* @brief this method adds connection between 2 variables, if they are in one gate, they are not constraint variables,
* and they have different indexes
* @tparam FF
* @param ultra_circuit_builder
Expand Down Expand Up @@ -821,4 +821,4 @@ template <typename FF> void Graph_<FF>::print_variables_edge_counts()
}
}

template class Graph_<bb::fr>;
template class Graph_<bb::fr>;
4 changes: 2 additions & 2 deletions cpp/src/barretenberg/client_ivc/client_ivc.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ TEST_F(ClientIVCTests, BasicFour)

/**
* @brief Check that the IVC fails if an intermediate fold proof is invalid
* @details When accumulating 4 circuits, there are 3 fold proofs to verify (the first two are recursively verfied and
* @details When accumulating 4 circuits, there are 3 fold proofs to verify (the first two are recursively verified and
* the 3rd is verified as part of the IVC proof). Check that if any of one of these proofs is invalid, the IVC will
* fail.
*
Expand Down Expand Up @@ -461,4 +461,4 @@ TEST_F(ClientIVCTests, DynamicOverflowCircuitSizeChange)

EXPECT_EQ(check_accumulator_target_sum_manual(ivc.fold_output.accumulator), true);
EXPECT_TRUE(ivc.prove_and_verify());
};
};