Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate deployment of ACR #19

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Automate deployment of ACR #19

merged 5 commits into from
Jun 26, 2024

Conversation

jgbradley1
Copy link
Collaborator

@jgbradley1 jgbradley1 commented Jun 26, 2024 •
edited
Loading

This PR adds the automatic creation/deployment of a container registry by default to the deployment script. This now removes a manual step in the deployment guide. Other changes include:

  • removed legacy code from HelloWorld notebook
  • converted all bicep code to a resource group deployment instead of a sub deployment
  • updated deployment guide with new instructions

@jgbradley1 jgbradley1 merged commit 69bb01d into main Jun 26, 2024
3 checks passed
@jgbradley1 jgbradley1 deleted the joshbradley/add-automatic-acr-deployment branch June 26, 2024 18:22
richardjortega pushed a commit that referenced this pull request Jun 26, 2024
@jgbradley1
Automate deployment of ACR (#19)
3e6ac4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jgbradley1