-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve host header even with extra trusted root certificates #1526
Open
chrismilson
wants to merge
3
commits into
Azure:master
Choose a base branch
from
chrismilson:preserve-host-header
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismilson
changed the title
Preserve host header
Preserve host header even with extra trusted root certificates
Apr 3, 2023
@microsoft-github-policy-service agree |
chrismilson
commented
Apr 3, 2023
Not sure how to get the Merge Builds check to succeed - error message is pretty non-descriptive. |
chrismilson
commented
Apr 21, 2023
httpSettings.PickHostNameFromBackendAddress = to.BoolPtr(true) | ||
if overrideBackendHostName, err := annotations.OverrideBackendHostName(backendID.Ingress); err == nil { | ||
if httpSettings.HostName != nil && !overrideBackendHostName { | ||
// TODO Warn about pointless setting of hostname |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the best way to implement this warning would be. Help would be appreciated.
The new annotation corresponds to the "Override with new host name" option in the backend settings blade in the Azure Portal.
chrismilson
force-pushed
the
preserve-host-header
branch
from
May 3, 2023 19:05
1ccfb6b
to
594d717
Compare
@akshaysngupta @alxyzc Could I please get a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes
.Description
/override-backend-hostname
;Fixes
#1520