{App Service} Skip failed tests to unblock CI #30289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @yanzhudd, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yonzhan,
jiasli,
kairu-ms,
bebound and
Pan-Qi
|
+@khkh-ms for awareness |
zhoxing-ms
approved these changes
Nov 8, 2024
wangzelin007
approved these changes
Nov 8, 2024
necusjz
approved these changes
Nov 8, 2024
bebound
approved these changes
Nov 8, 2024
|
Error detail: The error is raised from azure-cli/src/azure-cli/azure/cli/command_modules/appservice/custom.py Lines 4381 to 4383 in 14594a1 and the date is hard-coded in the YAML: "endOfLifeDate":"2024-11-08T00:00:00Z"So this check basically sets a time bomb and blows up the CI at exactly today. |
evelyn-ys
approved these changes
Nov 8, 2024
jiasli
approved these changes
Nov 8, 2024
3 tasks
3 tasks
jiasli
pushed a commit
to jiasli/azure-cli
that referenced
this pull request
Dec 18, 2024
jiasli
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Skip the tests temporarily to unblock CI:
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.