Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xff support #32484

Conversation

yaarark
Copy link

@yaarark yaarark commented Feb 6, 2025

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@yaarark yaarark requested a review from kamboj-prjwl as a code owner February 6, 2025 08:32
Copy link

openapi-pipeline-app bot commented Feb 6, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Feb 6, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork There is no API change compared with the previous version
JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=d0808755f0744bfe93198807d8be38cf

@yaarark
Copy link
Author

yaarark commented Feb 6, 2025

kamboj-prjwl I only added two Enum members, why it marked? BreakingChange-JavaScript-Sdk

@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 7, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 7, 2025
@yaarark
Copy link
Author

yaarark commented Feb 11, 2025

kamboj-prjwl Can you please review?

@kamboj-prjwl kamboj-prjwl merged commit 3ecf309 into Azure:kamboj-prjwl/release-network-Microsoft.Network-2024-07-01 Feb 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved customer-reported Issues that are reported by GitHub users external to the Azure organization. Network resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants