Restructuring of NFSProperties #24238
Open
+252
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashruti-msft
requested review from
souravgupta-msft,
jhendrixMSFT,
gapra-msft,
vibhansa-msft and
tanyasethi-msft
as code owners
There was a problem hiding this comment.
PR Overview
This PR restructures the handling of NFS properties in the Azure SDK for Go by introducing a new NFSProperties type and updating related models, examples, and tests. Key changes include:
- Introduction of a new NFSProperties type and associated formatting functions in the internal/exported package.
- Updates to directory and file models to use the new NFSProperties in creation, property setting, and HTTP header operations.
- Updates to examples and tests to demonstrate usage of NFSProperties.
Reviewed Changes
| File | Description |
|---|---|
| sdk/storage/azfile/internal/exported/nfs_property.go | Added new NFSProperties type and formatting functions |
| sdk/storage/azfile/directory/models.go | Updated CreateOptions and SetPropertiesOptions to include NFSProperties |
| sdk/storage/azfile/file/models.go | Added NFSProperties alias and updated create, header, and start-copy options |
| sdk/storage/azfile/file/examples_test.go | Updated examples to showcase NFSProperties usage |
| sdk/storage/azfile/directory/examples_test.go | Updated examples to showcase NFSProperties usage |
| sdk/storage/azfile/directory/client_test.go | Updated tests to include NFSProperties in directory operations |
| sdk/storage/azfile/file/client_test.go | Updated tests to include NFSProperties in file operations |
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Comment on lines
+365
to
+366
| FileModeCopyMode: o.FileModeCopyMode, | ||
| FileOwnerCopyMode: o.FileOwnerCopyMode, |
There was a problem hiding this comment.
Do we need this in case of NFS?
@vibhansa-msft ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructured all NFS Properties together.