Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Disable local auth when not in the isolated sub #32769

Merged
merged 12 commits into from
Feb 6, 2025
Merged

[Event Hubs] Disable local auth when not in the isolated sub #32769

merged 12 commits into from
Feb 6, 2025

Conversation

deyaaeldeen
Copy link
Member

Otherwise, resource creation fails.

@deyaaeldeen deyaaeldeen marked this pull request as ready for review January 28, 2025 23:05
@deyaaeldeen deyaaeldeen requested review from jeremymeng and a team as code owners January 28, 2025 23:05
@deyaaeldeen deyaaeldeen requested review from xirzec and a team as code owners January 29, 2025 20:17
weshaggard
weshaggard reviewed Jan 29, 2025
View reviewed changes
benbp
benbp reviewed Jan 29, 2025
View reviewed changes
@benbp benbp mentioned this pull request Jan 30, 2025
Merged
@deyaaeldeen deyaaeldeen requested a review from benbp February 5, 2025 19:12
@deyaaeldeen deyaaeldeen merged commit 6353087 into main Feb 6, 2025
17 checks passed
@deyaaeldeen deyaaeldeen deleted the eh-disable-local-auth branch February 6, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@richardpark-msft richardpark-msft richardpark-msft left review comments

@benbp benbp benbp approved these changes

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@xirzec xirzec Awaiting requested review from xirzec

@ckairen ckairen Awaiting requested review from ckairen

@mikeharder mikeharder Awaiting requested review from mikeharder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deyaaeldeen @benbp @weshaggard @richardpark-msft