-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix-based testing #2323
base: main
Are you sure you want to change the base?
Add matrix-based testing #2323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the one comment, I don't see anything obviously wrong, but @benbp might be a better reviewer here. And, at least as of when I wrote this, all the pipelines failed so there's something clearly wrong but I couldn't say what from what I see. But I don't see anything to hold the PR up.
SparseCheckoutPaths: | ||
- /* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SparseCheckoutPaths: | |
- /* |
I don't think you need this? It's just for checking out files that may be necessary for matrix generation outside of eng+service directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for PR matrix generation, I'll be back to needing it because I use cargo metadata
in LanguageSettings to get package metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So ci.yml
will need all the code because any of it may need to be built. Depending on how cargo handles partial workspaces, we may still need all the cargo.tomls to do the cargo metadata
call even when working with a single service directory.
default: | ||
- Name: rust_ci_test_base | ||
Path: eng/pipelines/templates/stages/platform-matrix.json | ||
Selection: sparse | ||
NonSparseParameters: RustToolchainName | ||
GenerateVMJobs: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way the matrix is set up now, you could specify it with all
instead. Though perhaps you have it with NonSparseParameters
to handle when more matrix parameters are added?
default: | |
- Name: rust_ci_test_base | |
Path: eng/pipelines/templates/stages/platform-matrix.json | |
Selection: sparse | |
NonSparseParameters: RustToolchainName | |
GenerateVMJobs: true | |
default: | |
- Name: rust_ci_test_base | |
Path: eng/pipelines/templates/stages/platform-matrix.json | |
Selection: all | |
GenerateVMJobs: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure how selection: all would interact with sparse coming from the PR matrix generation
No description provided.