[WIP] Missing Changes for Release 2.4.2 #1622
Open
+94
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
syeleti-msft
commented
Feb 4, 2025
•
syeleti-msft
commented
- Update renameFileOptions in fuse2 handler
- Update the ETag for dst attribute while renaming the file
- Sanitize the ETag in datalake before adding it to the attribute
- Invalidate the attribute in attribute cache after doing a truncate operation on file. This is sort of quick hack done to avoid the complexity of truncate file in az storage component.
- Add atomic_o_trunc flag in fuse2 options that will allow the fuse library to always pass the O_TRUNC flag on open call. see the comments in the code for more details
* update attribute cache while doing a commit operation on file.
* Fix sanitizing the etag in datalake
…ibrary to always pass the O_TRUNC flag on open call.
syeleti-msft
requested review from
souravgupta-msft,
ashruti-msft and
jainakanksha-msft
as code owners
syeleti-msft
changed the title
| @@ -589,7 +594,7 @@ func (ac *AttrCache) CommitData(options internal.CommitDataOptions) error { | |||
| if err == nil { | |||
| ac.cacheLock.RLock() | |||
| defer ac.cacheLock.RUnlock() | |||
|
|
|||
| // TODO: Could we just update the size, etag, modtime of the file here? | |||
There was a problem hiding this comment.
Looking this way.
We can check all the uses of invalidatePath.
syeleti-msft
force-pushed
the
syeleti/missingReleaseChanges
branch
from
ccea3cc to
09526c0
Compare
syeleti-msft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.