Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Availability Zone Functions #16673

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Availability Zone Functions #16673

wants to merge 2 commits into from

Conversation

jmorerice
Copy link
Contributor

@jmorerice jmorerice commented Mar 21, 2025

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Mar 21, 2025

Test this change out locally with the following install scripts (Action run 14047234080)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 14047234080
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 14047234080"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 14047234080
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 14047234080"

Copy link
Contributor

github-actions bot commented Mar 21, 2025

Dotnet Test Results

    78 files   -     39      78 suites   - 39   32m 57s ⏱️ - 18m 1s
11 912 tests  -     33  11 912 ✅  -     33  0 💤 ±0  0 ❌ ±0 
27 582 runs   - 13 846  27 582 ✅  - 13 846  0 💤 ±0  0 ❌ ±0 

Results for commit 08e0d18. ± Comparison against base commit 80a33d1.

This pull request removes 1811 and adds 615 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Խ
�0\u0010\u0000��>E�\u0003�I��V��"��\u0000�=�bki*\u0014�w7\u0015ĥť?���\u000c��\\u0012��\u0006t\u0006�!2\u0014�'hlԒ���w\u0018W��7��\u00122@\u0008��W��f\u001a]�R�8�\u0007\u0005\u0011�M^@�\u0014\u000f"!\u0004�DČ�B�l,\u001d��\u0018W�9%y�AK��Zv��P���t\u0006|�o�'���4���\u0000E��\u0011�#�Z\u0011��'�����ۗ�V�6�m�8@���Q_\u000c<���q\u001cǙ�\u0013|��$\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��K
� \u0010\u0006`�=�'0�q4]d�e� m�\u000fbJ\u001e$Pz�N\u0016�.\u0012�Ic�~Kg�Q�\u0015��
��\u001d��\u0011&E�\u0008�4I�֓�#І�}�LZ4�\u0018\u001f\u0016�dB״��Q���\u0007)�]{.�\u001c�V\u0019"��H\u0001�
7T:̕��\{�;��U�ť���_��>e4��\u0005�uK��/�b�)����Q���H�_%�����#�\u0004Q\u0014EQ\u0008O�e(�\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��O\u000b�0\u0014\u0000��\u0014�\u0007���\u001f
<\u0004\u001d2��k�\u001cd��\u001a\u0008}����tQ\u000b���ރ�m����nVF������0\u001a\u001a\u0001����\u0016�
Q�B\u0010QB2��f�J:ܫZ�P�\u0014g� \u00168��r\u0013Q�Y ��\u0004��\u000f��3���b4tn�>GY��\u0006_�kѦ�}�߾������=ѧ�'�#�\u0001���\u0011�#\u0002�\u000f�?IO�y�?�89,6���o\u0013w��\u0004�vM�eY����{��\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��K
�0\u0010\u0006�=EO��$����]z��\u0005\u001f4�>hA���Bp�⦶���\u0019��0�<ݻ~��c^�\��)gs�@\u0013��\u000fP!C�\u0002\u000c�R����}�\u0011mݸ*��Ĭ\u001f$l�s�ghHX���o�F@ڄ�a����5���W_v�_��\u000f
�T��\u001f�F���[3>�\u001f@0��|�4�!�(u��"�����\u001fko\u0010EQ\u0014��	W�2!\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003���\u000b� \u0014\u0007p��\u0015�?���i��]�.�\u0001��h�֘\u000b\u0006���;D��.�\u0011��\u000f�\u0013�J½i�`2�-�h�C��F�X���\u000e\u0013
1�F\u0011UR*�p;�$=�1�\u001be�^?�kl����)���B0"9�TG+��\u000e��5�LsN�2��\��ʋ���
���t=��F\u0002�?@�HƂ3Dc�x\�g������C	m\u0005i\u0003�\u000e�#��\u0006����s��<���\u0000�'��\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003���\u000b�0\u0014\u0007��+�����퇁��CFX\u0010t��B\u0006Z���?�<D\u0017��Z�>���{c|\u001fqw�Y�:Iˊ�T(���QC\u0000t��\u0018H��\u000bETr.\u0011����t�W�.�(S��A�º��4d\u0012<�9\u0000#�T\u0000���ݩ�\u0005���s�\u0015IڐKu-����ϴz��o�\u001e��O=@f\u0007H�s\u0001\u001eCTp��O��?��É��b\u0013-���6v��l�o�dY�e��	��5�\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createArray(1, 2, 3)","array","[
  1
  2
  3
]")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createObject('key', 'value')","object","{
  key: 'value'
}")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\n")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\r\n")
…

♻️ This comment has been updated with latest results.

@Gijsreyn
Copy link
Contributor

Is this pull request related to #15987?

@majastrz
Copy link
Member

Is this pull request related to #15987?

@Gijsreyn No, the functions that @jmorerice is adding in this PR are for a different scenario. The functions here are intended to convert between logical and physical availability zones. They are useful to co-locate zonal ARM resources within the same availability zone.

@jmorerice jmorerice requested a review from majastrz March 25, 2025 00:09
@Gijsreyn
Copy link
Contributor

Is this pull request related to #15987?

@Gijsreyn No, the functions that @jmorerice is adding in this PR are for a different scenario. The functions here are intended to convert between logical and physical availability zones. They are useful to co-locate zonal ARM resources within the same availability zone.

Oops okay! Thanks for the explanation.

@jmorerice jmorerice marked this pull request as ready for review March 25, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants