35v2 objective stress rates #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aradermacher
approved these changes
Jan 31, 2025
|
|
||
| if self.mesh_update: | ||
|
|
||
| # Update to current configuration |
There was a problem hiding this comment.
this code is nearly identically with the one in self.build_history (factor 0.5). Would it make sense to put that in an separate class function? And do we need to do the interpolation twice?
|
|
||
| mesh_update = True | ||
| co_rotation = True | ||
|
|
There was a problem hiding this comment.
Could you please add a small comment part describing the test and its purpose
|
The test are not yet working. Please have a look @saifr68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective stress rate is implemented and a test fie is written. Plots and paraview output files are created for the ease of review. Can be removed later