-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electrum indexer refactoring and bug fixing #63
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
=====================================
Coverage 0.0% 0.0%
=====================================
Files 23 23
Lines 2128 2071 -57
=====================================
+ Misses 2128 2071 -57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I am sorry, this is actually not true, I misread the previous code: the But still it is better to use simpler |
I have checked integration tests, they all do pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm all integration tests are working.
Alternative to #61 which additionally fixes other bugs and issues with the code:
bp-wallet/src/indexers/electrum.rs
Line 174 in dbfb8ba
expect
s in all data processings, which will result in global crashing and DDoS for all RGB wallets if a major electrum server used by them would be compromised or will have an API breakIt also removes overall convolution of the logic which makes it hard to review and audit
The PR leaves further required and important improvements for the later: #64