Replace logo appstore playmarket #1241
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
app/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json (1)
46-56: Consider removing legacy icon sizes.The 57x57 and 114x114 (57pt@1x,2x) sizes are legacy and only required for supporting iOS 6.1 and earlier. Unless you need to support very old iOS versions, these entries could be removed to simplify maintenance.
app/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/Contents.json (1)
46-49: Consider using more descriptive filenames without spaces.Current filenames like "40 1.png", "40 2.png" use numerical suffixes to distinguish between identical dimensions. Consider using more descriptive names that indicate the device type:
- "filename": "40 1.png", + "filename": "ipad_40x40_2x.png",This makes it easier to:
- Avoid potential build issues with spaces in filenames
- Quickly identify the purpose of each icon
- Maintain the asset catalog long-term
Also applies to: 64-67, 82-85
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (38)
app/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/1024.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/120 1.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/120.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/152.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/167.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/180.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/20.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/29 1.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/29.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/40 1.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/40 2.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/40.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/58 1.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/58.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/60.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/76.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/80 1.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/80.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/87.pngis excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/[email protected]is excluded by!**/*.pngapp/web/icons/Icon-192.pngis excluded by!**/*.pngapp/web/icons/Icon-512.pngis excluded by!**/*.pngapp/web/icons/Icon-maskable-192.pngis excluded by!**/*.pngapp/web/icons/Icon-maskable-512.pngis excluded by!**/*.png
📒 Files selected for processing (3)
app/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json(1 hunks)app/ios/Runner/Assets.xcassets/Contents.json(1 hunks)app/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/Contents.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- app/ios/Runner/Assets.xcassets/Contents.json
🔇 Additional comments (6)
app/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json (3)
76-79: LGTM!
The info section is correctly structured with appropriate metadata values.
1-2: LGTM!
The JSON structure follows Apple's asset catalog format and is well-organized.
Also applies to: 75-80
3-74: Verify the new Omi logo images.
While the icon size specifications are correct, please ensure:
- All referenced PNG files contain the new Omi logos
- The logos are properly centered and scaled in each image
- The images meet Apple's quality guidelines (no transparency, correct color space)
app/ios/Runner/Assets.xcassets/prodAppIcon.appiconset/Contents.json (3)
1-122: LGTM: All required iOS app icon sizes are present.
The asset catalog includes all mandatory icon sizes for iPhone, iPad, and App Store submission.
118-121: LGTM: Standard Xcode asset catalog metadata.
The info section contains the expected metadata for an Xcode-generated asset catalog.
2-116: Verify that the new Omi logo image files exist with correct dimensions.
|
better naming pls @sanjayamirthraj |
|
@sanjayamirthraj could you finish this task by a tiniy fix ? rename the files:
Ref: https://developer.apple.com/design/human-interface-guidelines/app-icons |
|
@sanjayamirthraj you can use https://icon.kitchen/ as well to generate the icons with correct names as requested by @beastoin |
|
@mdmohsin7 pls take over it. |
The names are properly changed I believe; this displays properly in local testing |
|
lgtm 🥳 @sanjayamirthraj @mdmohsin7 |
Changed logos to Omi logos
Summary by CodeRabbit
New Features
infosection in asset JSON files, providing metadata like author and version.Bug Fixes
Chores